Bug 113165 - Custom Elements Refactoring: The name V8CustomElement is confusing.
Summary: Custom Elements Refactoring: The name V8CustomElement is confusing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 99688
  Show dependency treegraph
 
Reported: 2013-03-24 18:49 PDT by Hajime Morrita
Modified: 2013-03-26 02:39 PDT (History)
7 users (show)

See Also:


Attachments
Patch (16.25 KB, patch)
2013-03-25 22:26 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2013-03-24 18:49:36 PDT
From bug 112191.
There is no CustomElement class in C++ side. So having this name breaks the convention
that expects the C++ class without "V8" prefix. It should have another name and
should be got rid of.
Comment 1 Hajime Morrita 2013-03-25 22:26:57 PDT
Created attachment 195006 [details]
Patch
Comment 2 Kent Tamura 2013-03-25 22:30:36 PDT
Comment on attachment 195006 [details]
Patch

rubber stamped
Comment 3 Hajime Morrita 2013-03-25 23:38:25 PDT
Committed r146851: <http://trac.webkit.org/changeset/146851>