Bug 112928 - [chromium] Remove SK_SUPPORT_HINTING_SCALE_FACTOR flag and code
Summary: [chromium] Remove SK_SUPPORT_HINTING_SCALE_FACTOR flag and code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Terry Anderson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 10:14 PDT by Terry Anderson
Modified: 2013-03-21 14:25 PDT (History)
5 users (show)

See Also:


Attachments
WIP, not for review (8.92 KB, patch)
2013-03-21 10:19 PDT, Terry Anderson
no flags Details | Formatted Diff | Diff
fixing merge conflict (8.84 KB, patch)
2013-03-21 14:02 PDT, Terry Anderson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Anderson 2013-03-21 10:14:34 PDT
This flag was only for ChromeOS builds with HighDPI. It is no longer needed and can be removed. See http://crbug.com/175506
Comment 1 Terry Anderson 2013-03-21 10:19:18 PDT
Created attachment 194288 [details]
WIP, not for review
Comment 2 Stephen White 2013-03-21 13:21:05 PDT
Comment on attachment 194288 [details]
WIP, not for review

OK.  r=me
Comment 3 WebKit Review Bot 2013-03-21 13:46:16 PDT
Comment on attachment 194288 [details]
WIP, not for review

Rejecting attachment 194288 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 194288, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
rce/WebKit/chromium/webkit/media/crypto/ppapi/cdm --revision 181763 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
58>At revision 181763.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/17206717
Comment 4 Terry Anderson 2013-03-21 14:02:52 PDT
Created attachment 194329 [details]
fixing merge conflict
Comment 5 WebKit Review Bot 2013-03-21 14:25:17 PDT
Comment on attachment 194329 [details]
fixing merge conflict

Clearing flags on attachment: 194329

Committed r146519: <http://trac.webkit.org/changeset/146519>
Comment 6 WebKit Review Bot 2013-03-21 14:25:20 PDT
All reviewed patches have been landed.  Closing bug.