Bug 112866 - [Shadow] Provide an api of insertionParent().
Summary: [Shadow] Provide an api of insertionParent().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 63606
  Show dependency treegraph
 
Reported: 2013-03-20 18:57 PDT by Hayato Ito
Modified: 2013-03-21 20:02 PDT (History)
6 users (show)

See Also:


Attachments
let me watch the result of ews (7.62 KB, patch)
2013-03-21 03:43 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2013-03-20 18:57:42 PDT
This is a bug in WebKit side.

The spec is here:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21067
Comment 1 Hayato Ito 2013-03-21 03:43:49 PDT
Created attachment 194218 [details]
let me watch the result of ews
Comment 2 Dimitri Glazkov (Google) 2013-03-21 09:36:43 PDT
Comment on attachment 194218 [details]
let me watch the result of ews

View in context: https://bugs.webkit.org/attachment.cgi?id=194218&action=review

> Source/WebCore/dom/Node.cpp:1277
> +Node* Node::insertionParentForBinding() const

is ForBinding the common pattern we use for these things?
Comment 3 Hayato Ito 2013-03-21 19:35:02 PDT
Thank you for the review. Let me land this.

(In reply to comment #2)
> (From update of attachment 194218 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=194218&action=review
> 
> > Source/WebCore/dom/Node.cpp:1277
> > +Node* Node::insertionParentForBinding() const
> 
> is ForBinding the common pattern we use for these things?

I am not sure this is the common patter. I could not find the convention.
I'm totally okay to change the name if we find a good convention.
Comment 4 WebKit Review Bot 2013-03-21 20:02:25 PDT
Comment on attachment 194218 [details]
let me watch the result of ews

Clearing flags on attachment: 194218

Committed r146555: <http://trac.webkit.org/changeset/146555>
Comment 5 WebKit Review Bot 2013-03-21 20:02:30 PDT
All reviewed patches have been landed.  Closing bug.