RESOLVED FIXED112690
Web Inspector: [DataGrid] Refactorings. 
https://bugs.webkit.org/show_bug.cgi?id=112690
Summary Web Inspector: [DataGrid] Refactorings.
Eugene Klyuchnikov
Reported 2013-03-19 06:25:45 PDT
1. Avoid using string literals; 2. Remove unused notifications; 3. Replace some getters with regular functions;
Attachments
Patch (45.19 KB, patch)
2013-03-19 06:30 PDT, Eugene Klyuchnikov 		pfeldman: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-19 06:30:06 PDT
Created attachment 193809 [details] Patch
WebKit Review Bot
Comment 2 2013-03-20 02:48:56 PDT
Comment on attachment 193809 [details] Patch Rejecting attachment 193809 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 193809, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-commit-queue.appspot.com/results/17223347
Eugene Klyuchnikov
Comment 3 2013-03-20 04:32:49 PDT
Committed r146325: <http://trac.webkit.org/changeset/146325>
Note You need to log in before you can comment on or make changes to this bug.