WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
112553
Web Inspector: fix context menus capitalization
https://bugs.webkit.org/show_bug.cgi?id=112553
Summary
Web Inspector: fix context menus capitalization
Alexei Filippov
Reported
2013-03-18 03:45:48 PDT
Created
attachment 193519
[details]
screenshot Context menus should be correctly capitalized. E.g. see screenshot.
Attachments
screenshot
(68.96 KB, image/png)
2013-03-18 03:45 PDT
,
Alexei Filippov
no flags
Details
Patch
(42.26 KB, patch)
2013-03-18 03:50 PDT
,
Alexei Filippov
no flags
Details
Formatted Diff
Diff
Patch
(42.26 KB, patch)
2013-03-19 10:20 PDT
,
Alexei Filippov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexei Filippov
Comment 1
2013-03-18 03:50:52 PDT
Created
attachment 193520
[details]
Patch
WebKit Review Bot
Comment 2
2013-03-19 10:08:31 PDT
Comment on
attachment 193520
[details]
Patch Rejecting
attachment 193520
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 193520, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: rce/WebKit/chromium/webkit/media/crypto/ppapi/cdm --revision 181763 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 58>At revision 181763. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output:
http://webkit-commit-queue.appspot.com/results/17200445
Alexei Filippov
Comment 3
2013-03-19 10:20:38 PDT
Created
attachment 193852
[details]
Patch
Alexei Filippov
Comment 4
2013-03-19 10:20:55 PDT
Rebaselined.
WebKit Review Bot
Comment 5
2013-03-19 10:45:54 PDT
Comment on
attachment 193852
[details]
Patch Clearing flags on attachment: 193852 Committed
r146220
: <
http://trac.webkit.org/changeset/146220
>
WebKit Review Bot
Comment 6
2013-03-19 10:45:57 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 7
2013-03-19 12:27:16 PDT
This patch caused 140 tests to fail on Mac with errors like: UIString.js:44: CONSOLEAPI WARN: Localized string "Logs" not found.
Ryosuke Niwa
Comment 8
2013-03-19 12:32:29 PDT
e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r146221%20(7923)/results.html
Ryosuke Niwa
Comment 9
2013-03-19 12:39:15 PDT
Fixed it in
http://trac.webkit.org/changeset/146238
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug