WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
112390
[chromium] Remove the zoom filter operation ifdef
https://bugs.webkit.org/show_bug.cgi?id=112390
Summary
[chromium] Remove the zoom filter operation ifdef
Dana Jansens
Reported
2013-03-14 16:30:25 PDT
[chromium] Remove the zoom filter operation ifdef
Attachments
Patch
(1.68 KB, patch)
2013-03-14 16:31 PDT
,
Dana Jansens
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dana Jansens
Comment 1
2013-03-14 16:31:21 PDT
Created
attachment 193198
[details]
Patch
Dana Jansens
Comment 2
2013-03-14 16:31:49 PDT
This should land once
https://codereview.chromium.org/12630014/
lands.
WebKit Review Bot
Comment 3
2013-03-14 16:34:30 PDT
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
WebKit Review Bot
Comment 4
2013-03-17 10:03:43 PDT
Comment on
attachment 193198
[details]
Patch Rejecting
attachment 193198
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ty/skia/gyp --revision 8166 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 103. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' Died at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2628. Full output:
http://webkit-commit-queue.appspot.com/results/17215343
WebKit Review Bot
Comment 5
2013-03-17 10:15:00 PDT
Comment on
attachment 193198
[details]
Patch Clearing flags on attachment: 193198 Committed
r146013
: <
http://trac.webkit.org/changeset/146013
>
WebKit Review Bot
Comment 6
2013-03-17 10:15:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug