Bug 112390 - [chromium] Remove the zoom filter operation ifdef
Summary: [chromium] Remove the zoom filter operation ifdef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-14 16:30 PDT by Dana Jansens
Modified: 2013-03-17 10:15 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2013-03-14 16:31 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2013-03-14 16:30:25 PDT
[chromium] Remove the zoom filter operation ifdef
Comment 1 Dana Jansens 2013-03-14 16:31:21 PDT
Created attachment 193198 [details]
Patch
Comment 2 Dana Jansens 2013-03-14 16:31:49 PDT
This should land once https://codereview.chromium.org/12630014/ lands.
Comment 3 WebKit Review Bot 2013-03-14 16:34:30 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-03-17 10:03:43 PDT
Comment on attachment 193198 [details]
Patch

Rejecting attachment 193198 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ty/skia/gyp --revision 8166 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium
Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 103.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
Died at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2628.

Full output: http://webkit-commit-queue.appspot.com/results/17215343
Comment 5 WebKit Review Bot 2013-03-17 10:15:00 PDT
Comment on attachment 193198 [details]
Patch

Clearing flags on attachment: 193198

Committed r146013: <http://trac.webkit.org/changeset/146013>
Comment 6 WebKit Review Bot 2013-03-17 10:15:03 PDT
All reviewed patches have been landed.  Closing bug.