Bug for the last bits of DeprecatedStringList removal.
Created attachment 10982 [details] work in progress, maybe Anders can use some of this I was working on this for a while, but I moved to doing something else. Here's my work in progress in case it's useful.
The parts of Darin's patch which deal with the Objective-C DOM bindings was landed in r16947.
Created attachment 13205 [details] first attempt It seems this is all needed to remove DeprecatedStringList. There seem to be no regressions, but I hope someone familiar with the editing code can check. Cheers, Rob.
Created attachment 13215 [details] Improved patch This patch has improved iterator logic, after a suggestion from Sam. Hopefully someone can performance test the patch :) All tests pass fine. Cheers, Rob.
Comment on attachment 13205 [details] first attempt + bool atParagraphEnd = nextTab == -1 || nextTab > paragraphEnd; I believe this should be >=
Should wait until after stabilization period I assume.
Created attachment 13224 [details] Improved patch II I added Darin's suggestion. I am ok with waiting until the stabilization is over, so I didnt set the review flag. Cheers, Rob.
Comment on attachment 13224 [details] Improved patch II I think it's best to set the review? flag so this patch doesn't get lost. Reviewers and committers should be reading the bug so that they understand it shouldn't be committed until after stabilization.
I'd rather the flag be cleared personally. This is like the sixth time I've stumbled into this bug while examining the list.
Comment on attachment 13224 [details] Improved patch II Clearing review per Comment #9. Is there a way to search for these bugs once the flags are cleared?
Sam fixed this today.