Bug 112037 - Web Inspector: Fix checkContentUpdated behavior in UISourceCode.
Summary: Web Inspector: Fix checkContentUpdated behavior in UISourceCode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 10:34 PDT by Vsevolod Vlasov
Modified: 2013-03-12 07:55 PDT (History)
12 users (show)

See Also:


Attachments
Patch (7.57 KB, patch)
2013-03-11 10:36 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (9.51 KB, patch)
2013-03-12 04:25 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2013-03-11 10:34:24 PDT
Currently checkContentUpdated works unreliably.
It should also save last updated content that was loaded and rejected by user on the per-file basis (only the last one is saved currently)
Comment 1 Vsevolod Vlasov 2013-03-11 10:36:24 PDT
Created attachment 192502 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-11 11:29:11 PDT
Comment on attachment 192502 [details]
Patch

Attachment 192502 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17156243

New failing tests:
inspector/debugger/scripts-panel.html
inspector/debugger/live-edit-breakpoints.html
inspector/debugger/live-edit.html
Comment 3 Build Bot 2013-03-11 19:09:49 PDT
Comment on attachment 192502 [details]
Patch

Attachment 192502 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17178146

New failing tests:
inspector/debugger/scripts-panel.html
Comment 4 Vsevolod Vlasov 2013-03-12 04:25:44 PDT
Created attachment 192708 [details]
Patch
Comment 5 WebKit Review Bot 2013-03-12 07:55:44 PDT
Comment on attachment 192708 [details]
Patch

Clearing flags on attachment: 192708

Committed r145543: <http://trac.webkit.org/changeset/145543>
Comment 6 WebKit Review Bot 2013-03-12 07:55:48 PDT
All reviewed patches have been landed.  Closing bug.