Bug 112033 - [GTK] WebKit2-only build fails
Summary: [GTK] WebKit2-only build fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 09:21 PDT by Zan Dobersek
Modified: 2013-03-11 13:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2013-03-11 09:25 PDT, Zan Dobersek 		gustavo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-03-11 09:21:35 PDT 
[GTK] WebKit2-only build fails
Comment 1 Zan Dobersek 2013-03-11 09:25:58 PDT 
Created attachment 192484 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-03-11 10:36:30 PDT 
Comment on attachment 192484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192484&action=review

> Tools/GNUmakefile.am:322
>  	Source/WebKit/gtk/docs/webkitgtk-docs.sgml \
> -	Source/WebKit/gtk/docs/webkitgtk-sections.txt \
> -	libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la \
> +	Source/WebKit/gtk/docs/webkitgtk-sections.txt

Should these sgml and sections.txt also be under ENABLE_WEBKIT1?
Comment 3 Zan Dobersek 2013-03-11 13:13:07 PDT 
Comment on attachment 192484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192484&action=review

>> Tools/GNUmakefile.am:322
>> +	Source/WebKit/gtk/docs/webkitgtk-sections.txt
> 
> Should these sgml and sections.txt also be under ENABLE_WEBKIT1?

Yes. I was keeping the current behavior, but as far as I understand there's no reason for these two files to be among the dependencies for docs-build.stamp when WebKit1 is not building.
Comment 4 Zan Dobersek 2013-03-11 13:24:28 PDT 
Committed r145395: <http://trac.webkit.org/changeset/145395>