Bug 111776 - REGRESSION: fast/border/border-fit-2.html needs updating
Summary: REGRESSION: fast/border/border-fit-2.html needs updating
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-07 14:26 PST by Dave Hyatt
Modified: 2013-03-13 21:17 PDT (History)
3 users (show)

See Also:

Attachments
Patch (22.88 KB, patch)
2013-03-07 14:30 PST, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-03-07 14:26:36 PST 
This test is incorrectly shrinking the border image because we need to apply some clamping to the border-fit. The pixel results *are* still changing though, since a layout-time shrinkage will not result in right-aligned boxes in an LTR block when the left edge gets chopped. We'll have to see if this behavioral change ends up being a problem, but for now we'll rebaseline and assume it will be ok.
Comment 1 Dave Hyatt 2013-03-07 14:30:08 PST 
Created attachment 192085 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-03-07 14:31:46 PST 
Comment on attachment 192085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192085&action=review

> Source/WebCore/ChangeLog:10
> +        old code did.. The pixel results *are* still changing though,

Two periods.

> Source/WebCore/ChangeLog:26
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests (OOPS!).

OOPS!
Comment 3 Dave Hyatt 2013-03-07 14:36:35 PST 
Landed in r145139.
Comment 4 Eric Seidel (no email) 2013-03-07 14:37:20 PST 
Someone should tell hyatt about webkit-patch land, which magically updates the bug for you. :)
Comment 5 Radar WebKit Bug Importer 2013-03-13 21:17:50 PDT 
<rdar://problem/13417623>