Bug 111656 - OpenGLShims: fix check for ANGLE GLES2 extensions
Summary: OpenGLShims: fix check for ANGLE GLES2 extensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 18:02 PST by Sergio Correia (qrwteyrutiyoup)
Modified: 2013-03-07 07:56 PST (History)
3 users (show)

See Also:

Attachments
Proposed patch (952 bytes, patch)
2013-03-06 18:06 PST, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Patch (1.53 KB, patch)
2013-03-07 07:30 PST, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Correia (qrwteyrutiyoup) 2013-03-06 18:02:12 PST 
OpenGLShims: fix check for ANGLE GLES2 extensions
Comment 1 Sergio Correia (qrwteyrutiyoup) 2013-03-06 18:06:50 PST 
Created attachment 191878 [details]
Proposed patch
Comment 2 Sergio Correia (qrwteyrutiyoup) 2013-03-06 18:16:30 PST 
The check for ANGLE GLES2 extensions is currently being overriden with checks for APPLE extensions in lookupOpenGLFunctionAddress()
Comment 3 Simon Hausmann 2013-03-07 06:48:06 PST 
Comment on attachment 191878 [details]
Proposed patch

Good catch!

r- due to missing ChangeLog though.
Comment 4 Sergio Correia (qrwteyrutiyoup) 2013-03-07 07:01:07 PST 
(In reply to comment #3)
> (From update of attachment 191878 [details])
> Good catch!
> 
> r- due to missing ChangeLog though.

Sure, I will update this :)
Comment 5 Sergio Correia (qrwteyrutiyoup) 2013-03-07 07:30:30 PST 
Created attachment 191993 [details]
Patch

Proposed patch
Comment 6 WebKit Review Bot 2013-03-07 07:56:38 PST 
Comment on attachment 191993 [details]
Patch

Clearing flags on attachment: 191993

Committed r145079: <http://trac.webkit.org/changeset/145079>
Comment 7 WebKit Review Bot 2013-03-07 07:56:42 PST 
All reviewed patches have been landed.  Closing bug.