Bug 111636 - RenderFullScreen should call setNeedsLayoutAndPrefWidthsRecalc on the child (?)
Summary: RenderFullScreen should call setNeedsLayoutAndPrefWidthsRecalc on the child (?)
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 15:46 PST by Christian Biesinger
Modified: 2017-07-18 08:29 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Biesinger 2013-03-06 15:46:30 PST
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFullScreen.cpp?rev=HEAD#L154

The code here looks like:
154	        while ((child = firstChild())) {
155	            child->remove();
156	            parent()->addChild(child, this);
157	            parent()->setNeedsLayoutAndPrefWidthsRecalc();
158	        }

It seems to me like setNeedsLayoutAndPrefWidthsRecalc() should be called on the child (which then would recurse through the parents).

hyatt, does that seem plausible? At least, if it is right to call it on the parent, it should be outside the loop.

(I don't have a testcase either way, we found this by code inspection)