WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111632
[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
https://bugs.webkit.org/show_bug.cgi?id=111632
Summary
[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
James Robinson
Reported
2013-03-06 15:14:41 PST
[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
Attachments
Patch
(16.09 KB, patch)
2013-03-06 15:16 PST
,
James Robinson
no flags
Details
Formatted Diff
Diff
add back empty definition of WLTV::Settings since this can't be forward declared
(16.28 KB, patch)
2013-03-06 15:22 PST
,
James Robinson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2013-03-06 15:16:23 PST
Created
attachment 191845
[details]
Patch
James Robinson
Comment 2
2013-03-06 15:17:02 PST
Depends on
https://codereview.chromium.org/12472015/
WebKit Review Bot
Comment 3
2013-03-06 15:18:24 PST
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
Adrienne Walker
Comment 4
2013-03-06 15:21:07 PST
Comment on
attachment 191845
[details]
Patch R=me. \o/
James Robinson
Comment 5
2013-03-06 15:22:09 PST
Created
attachment 191849
[details]
add back empty definition of WLTV::Settings since this can't be forward declared
Adrienne Walker
Comment 6
2013-03-06 15:29:08 PST
Comment on
attachment 191849
[details]
add back empty definition of WLTV::Settings since this can't be forward declared R=me. Oh, C++.
WebKit Review Bot
Comment 7
2013-03-08 13:04:06 PST
Comment on
attachment 191849
[details]
add back empty definition of WLTV::Settings since this can't be forward declared Clearing flags on attachment: 191849 Committed
r145258
: <
http://trac.webkit.org/changeset/145258
>
WebKit Review Bot
Comment 8
2013-03-08 13:04:11 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug