Bug 111632 - [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
Summary: [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 15:14 PST by James Robinson
Modified: 2013-03-08 13:04 PST (History)
6 users (show)

See Also:

Attachments
Patch (16.09 KB, patch)
2013-03-06 15:16 PST, James Robinson 		no flags Details | Formatted Diff | Diff
add back empty definition of WLTV::Settings since this can't be forward declared (16.28 KB, patch)
2013-03-06 15:22 PST, James Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-03-06 15:14:41 PST 
[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
Comment 1 James Robinson 2013-03-06 15:16:23 PST 
Created attachment 191845 [details]
Patch
Comment 2 James Robinson 2013-03-06 15:17:02 PST 
Depends on https://codereview.chromium.org/12472015/
Comment 3 WebKit Review Bot 2013-03-06 15:18:24 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adrienne Walker 2013-03-06 15:21:07 PST 
Comment on attachment 191845 [details]
Patch

R=me.  \o/
Comment 5 James Robinson 2013-03-06 15:22:09 PST 
Created attachment 191849 [details]
add back empty definition of WLTV::Settings since this can't be forward declared
Comment 6 Adrienne Walker 2013-03-06 15:29:08 PST 
Comment on attachment 191849 [details]
add back empty definition of WLTV::Settings since this can't be forward declared

R=me.  Oh, C++.
Comment 7 WebKit Review Bot 2013-03-08 13:04:06 PST 
Comment on attachment 191849 [details]
add back empty definition of WLTV::Settings since this can't be forward declared

Clearing flags on attachment: 191849

Committed r145258: <http://trac.webkit.org/changeset/145258>
Comment 8 WebKit Review Bot 2013-03-08 13:04:11 PST 
All reviewed patches have been landed.  Closing bug.