Bug 111576 - Web Inspector: [ACE] gutter size should be fixed.
Summary: Web Inspector: [ACE] gutter size should be fixed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 06:42 PST by Andrey Lushnikov
Modified: 2013-03-07 04:58 PST (History)
9 users (show)

See Also:

Attachments
Patch (196.79 KB, patch)
2013-03-06 06:46 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (196.77 KB, patch)
2013-03-07 02:22 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-06 06:42:44 PST 
The gutter's width has size of its last visible line number. So when you scroll a file with lots of lines, gutter gets expanded more and more (as the amount of digits in line number increases).
It a perfect word, it should be of the same size all the time.
Comment 1 Andrey Lushnikov 2013-03-06 06:46:25 PST 
Created attachment 191744 [details]
Patch
Comment 2 Pavel Feldman 2013-03-06 07:12:45 PST 
Comment on attachment 191744 [details]
Patch

You should not change third party files in place. This diverges things and results in merging conflicts.
Comment 3 Andrey Lushnikov 2013-03-07 02:22:39 PST 
Created attachment 191956 [details]
Patch
Comment 4 WebKit Review Bot 2013-03-07 04:58:00 PST 
Comment on attachment 191956 [details]
Patch

Clearing flags on attachment: 191956

Committed r145064: <http://trac.webkit.org/changeset/145064>
Comment 5 WebKit Review Bot 2013-03-07 04:58:04 PST 
All reviewed patches have been landed.  Closing bug.