RESOLVED FIXED111499
[chromium] Remove WebView's sharedGraphicsContext3D method.
https://bugs.webkit.org/show_bug.cgi?id=111499
Summary [chromium] Remove WebView's sharedGraphicsContext3D method.
Dana Jansens
Reported 2013-03-05 17:00:55 PST
[chromium] Remove WebView's sharedGraphicsContext3D method.
Attachments
Patch (3.13 KB, patch)
2013-03-05 17:01 PST, Dana Jansens
no flags
Patch (3.23 KB, patch)
2013-03-05 17:07 PST, Dana Jansens
no flags
Dana Jansens
Comment 1 2013-03-05 17:01:11 PST
Dana Jansens
Comment 2 2013-03-05 17:01:47 PST
This depends on https://codereview.chromium.org/12506003/ on the chromium side which needs to land still. But once it does, we can remove this method.
WebKit Review Bot
Comment 3 2013-03-05 17:04:02 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 4 2013-03-05 17:04:28 PST
Comment on attachment 191605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191605&action=review > Source/WebKit/chromium/public/WebView.h:-469 > // GPU acceleration support -------------------------------------------- > > - // Context that's in the compositor's share group, but is not the compositor context itself. > - // Can be used for allocating resources that the compositor will later access. > - virtual WebGraphicsContext3D* sharedGraphicsContext3D() = 0; > - You can delete the "GPU acceleration support" comment too since nothing below here has to do with GPU stuff, really
Dana Jansens
Comment 5 2013-03-05 17:07:05 PST
Created attachment 191607 [details] Patch Thanks! Done.
WebKit Review Bot
Comment 6 2013-03-07 10:00:44 PST
Comment on attachment 191607 [details] Patch Clearing flags on attachment: 191607 Committed r145091: <http://trac.webkit.org/changeset/145091>
WebKit Review Bot
Comment 7 2013-03-07 10:00:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.