Bug 111499 - [chromium] Remove WebView's sharedGraphicsContext3D method.
Summary: [chromium] Remove WebView's sharedGraphicsContext3D method.
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
Depends on:
Reported: 2013-03-05 17:00 PST by Dana Jansens
Modified: 2013-03-07 10:00 PST (History)
8 users (show)

See Also:

Patch (3.13 KB, patch)
2013-03-05 17:01 PST, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (3.23 KB, patch)
2013-03-05 17:07 PST, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2013-03-05 17:00:55 PST
[chromium] Remove WebView's sharedGraphicsContext3D method.
Comment 1 Dana Jansens 2013-03-05 17:01:11 PST
Created attachment 191605 [details]
Comment 2 Dana Jansens 2013-03-05 17:01:47 PST
This depends on https://codereview.chromium.org/12506003/ on the chromium side which needs to land still. But once it does, we can remove this method.
Comment 3 WebKit Review Bot 2013-03-05 17:04:02 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 James Robinson 2013-03-05 17:04:28 PST
Comment on attachment 191605 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=191605&action=review

> Source/WebKit/chromium/public/WebView.h:-469
>      // GPU acceleration support --------------------------------------------
> -    // Context that's in the compositor's share group, but is not the compositor context itself.
> -    // Can be used for allocating resources that the compositor will later access.
> -    virtual WebGraphicsContext3D* sharedGraphicsContext3D() = 0;
> -

You can delete the "GPU acceleration support" comment too since nothing below here has to do with GPU stuff, really
Comment 5 Dana Jansens 2013-03-05 17:07:05 PST
Created attachment 191607 [details]

Thanks! Done.
Comment 6 WebKit Review Bot 2013-03-07 10:00:44 PST
Comment on attachment 191607 [details]

Clearing flags on attachment: 191607

Committed r145091: <http://trac.webkit.org/changeset/145091>
Comment 7 WebKit Review Bot 2013-03-07 10:00:51 PST
All reviewed patches have been landed.  Closing bug.