Bug 111428 - [EFL][WebGL] Enable webgl-background-color test.
Summary: [EFL][WebGL] Enable webgl-background-color test.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Kalyan
URL:
Keywords:
Depends on:
Blocks: 105093
  Show dependency treegraph
 
Reported: 2013-03-05 05:10 PST by Kalyan
Modified: 2013-06-08 16:58 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.88 KB, patch)
2013-03-05 05:31 PST, Kalyan
no flags Details | Formatted Diff | Diff
Patch (7.85 KB, patch)
2013-03-05 20:11 PST, Kalyan
no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2013-06-08 16:25 PDT, Kalyan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalyan 2013-03-05 05:10:27 PST
Currently, the test misses Test expectation files.
Comment 1 Kalyan 2013-03-05 05:31:04 PST
Created attachment 191474 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-05 05:33:16 PST
Attachment 191474 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.png', u'LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.txt']" exit_code: 1
LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kalyan 2013-03-05 20:11:14 PST
Created attachment 191643 [details]
Patch
Comment 4 WebKit Review Bot 2013-03-05 20:14:33 PST
Attachment 191643 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.png', u'LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.txt']" exit_code: 1
LayoutTests/platform/efl/compositing/webgl/webgl-background-color-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2013-05-16 13:12:38 PDT
Comment on attachment 191643 [details]
Patch

Just so you know, such patch does not really need review but r=me anyway.
Comment 6 Kalyan 2013-06-08 16:25:44 PDT
Created attachment 204100 [details]
Patch
Comment 7 WebKit Commit Bot 2013-06-08 16:58:18 PDT
Comment on attachment 204100 [details]
Patch

Clearing flags on attachment: 204100

Committed r151350: <http://trac.webkit.org/changeset/151350>
Comment 8 WebKit Commit Bot 2013-06-08 16:58:21 PDT
All reviewed patches have been landed.  Closing bug.