Bug 111261 - REGRESSION(144520): Does not compile on chromium-win
Summary: REGRESSION(144520): Does not compile on chromium-win
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 110995
  Show dependency treegraph
 
Reported: 2013-03-03 00:18 PST by Adam Barth
Modified: 2013-03-03 00:35 PST (History)
0 users

See Also:


Attachments
Patch (9.30 KB, patch)
2013-03-03 00:20 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-03-03 00:18:52 PST
REGRESSION(144520): Does not compile on chromium-win
Comment 1 Adam Barth 2013-03-03 00:20:12 PST
Created attachment 191129 [details]
Patch
Comment 2 Adam Barth 2013-03-03 00:22:53 PST
179>C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/OwnPtrCommon.h(63):error C2248: 'WebCore::RenderBlock::RenderBlockRareData' : cannot access protected struct declared in class 'WebCore::RenderBlock'
179>          c:\b\build\slave\webkit-win-latest-rel\build\src\third_party\webkit\source\webcore\rendering\RenderBlock.h(1214) : see declaration of 'WebCore::RenderBlock::RenderBlockRareData'
179>          c:\b\build\slave\webkit-win-latest-rel\build\src\third_party\webkit\source\webcore\rendering\RenderBlock.h(83) : see declaration of 'WebCore::RenderBlock'
179>          C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassOwnPtr.h(56) : see reference to function template instantiation 'void WTF::deleteOwnedPtr<WebCore::RenderBlock::RenderBlockRareData>(T *)' being compiled
179>          with
179>          [
179>              T=WebCore::RenderBlock::RenderBlockRareData
179>          ]
179>          C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassOwnPtr.h(56) : while compiling class template member function 'WTF::PassOwnPtr<T>::~PassOwnPtr(void)'
179>          with
179>          [
179>              T=WebCore::RenderBlock::RenderBlockRareData
179>          ]
179>          c:\b\build\slave\webkit-win-latest-rel\build\src\third_party\webkit\source\webcore\rendering\RenderBlock.h(336) : see reference to class template instantiation 'WTF::PassOwnPtr<T>' being compiled
179>          with
179>          [
179>              T=WebCore::RenderBlock::RenderBlockRareData
179>          ]
Comment 4 Adam Barth 2013-03-03 00:35:33 PST
Comment on attachment 191129 [details]
Patch

Clearing flags on attachment: 191129

Committed r144561: <http://trac.webkit.org/changeset/144561>
Comment 5 Adam Barth 2013-03-03 00:35:35 PST
All reviewed patches have been landed.  Closing bug.