Bug 111224 - [chromium] Mark some software compositing tests as failing before landing anti-aliasing changes
Summary: [chromium] Mark some software compositing tests as failing before landing ant...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Reveman
URL:
Keywords:
Depends on:
Blocks: 111227
  Show dependency treegraph
 
Reported: 2013-03-01 14:46 PST by David Reveman
Modified: 2013-03-01 15:27 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.78 KB, patch)
2013-03-01 14:50 PST, David Reveman
jamesr: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Reveman 2013-03-01 14:46:48 PST
Need to rebaseline these tests after landing chromium aa changes:

platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep.html
platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children.html
platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited.html
platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection.html

chromium patch that need this: https://codereview.chromium.org/12328098/
Comment 1 David Reveman 2013-03-01 14:50:35 PST
Created attachment 191042 [details]
Patch
Comment 2 James Robinson 2013-03-01 14:56:23 PST
If you get conflicts, which you are likely to do, try adding new lines like this a bit away from the very end of the file.
Comment 3 WebKit Review Bot 2013-03-01 14:58:17 PST
Comment on attachment 191042 [details]
Patch

Rejecting attachment 191042 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 191042, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/TestExpectations
Hunk #1 FAILED at 4457.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/TestExpectations.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'James Robinson']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/16800112