Bug 111100 - Create BlobRegistry through a strategy
Summary: Create BlobRegistry through a strategy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-28 12:12 PST by Alexey Proskuryakov
Modified: 2013-03-01 11:20 PST (History)
9 users (show)

See Also:


Attachments
proposed patch (22.26 KB, patch)
2013-02-28 12:19 PST, Alexey Proskuryakov
sam: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-02-28 12:12:32 PST
BlobRegistry is used in WebCore, so we need to switch between in-process and proxy versions dynamically.
Comment 1 Alexey Proskuryakov 2013-02-28 12:19:50 PST
Created attachment 190780 [details]
proposed patch
Comment 2 WebKit Review Bot 2013-02-28 12:23:05 PST
Attachment 190780 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/loader/LoaderStrategy.cpp', u'Source/WebCore/loader/LoaderStrategy.h', u'Source/WebCore/platform/network/BlobData.h', u'Source/WebCore/platform/network/BlobRegistry.cpp', u'Source/WebCore/platform/network/BlobRegistry.h', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.h', u'Source/WebCore/platform/network/BlobStorageData.h', u'Source/WebCore/platform/network/FormData.cpp', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm']" exit_code: 1
Source/WebCore/ChangeLog:18:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/platform/network/BlobRegistryImpl.h:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2013-02-28 12:41:16 PST
Comment on attachment 190780 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190780&action=review

> Source/WebCore/platform/network/FormData.cpp:326
> +        LOG_ERROR("Tried to resolve a blob in a wrong process");

This error seems hard to understand.  Can we still provide an error without referring to the fact that there might be more than one process?
Comment 4 WebKit Review Bot 2013-02-28 13:05:33 PST
Comment on attachment 190780 [details]
proposed patch

Attachment 190780 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16857035
Comment 5 Alexey Proskuryakov 2013-02-28 13:06:35 PST
Already committed, <http://trac.webkit.org/changeset/144353>.
Comment 6 Alexey Proskuryakov 2013-02-28 13:10:41 PST
Attempted build fix in <http://trac.webkit.org/changeset/144354>.
Comment 7 Csaba Osztrogonác 2013-03-01 03:40:46 PST
It broke the !ENABLE(BLOB) builds:

g++ -c -Wall -Wextra -Wreturn-type -fno-strict-aliasing -Wchar-subscripts -Wformat-security -Wreturn-type -Wno-unused-parameter -Wno-sign-compare -Wno-switch -Wno-switch-enum -Wundef -Wmissing-noreturn -Winit-self -pipe -ffunction-sections -fdata-sections -march=pentium4 -msse2 -mfpmath=sse -Werror -Wno-c++0x-compat -O2 -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -pthread -pthread -pthread -pthread -pthread -pthread -pthread -pthread -fno-exceptions -D_REENTRANT -DQT_NO_LIBUDEV -DWTF_USE_GLIB=1 -DGST_API_VERSION=1.0 -DGST_API_VERSION_1 -DQT_OPENGL_SHIMS=1 -DBUILDING_QT__=1 -DNDEBUG -DENABLE_FAST_MOBILE_SCROLLING=1 -DENABLE_GESTURE_EVENTS=1 -DENABLE_LEGACY_VIEWPORT_ADAPTION=1 -DENABLE_TOUCH_ADJUSTMENT=1 -DWTF_USE_TILED_BACKING_STORE=1 -DHAVE_QTQUICK=1 -DHAVE_QTPRINTSUPPORT=1 -DHAVE_QSTYLE=1 -DHAVE_QTTESTLIB=1 -DWTF_USE_LIBXML2=1 -DWTF_USE_ZLIB=1 -DWTF_USE_LIBJPEG=1 -DWTF_USE_LIBPNG=1 -DHAVE_XCOMPOSITE=1 -DHAVE_XRENDER=1 -DHAVE_GLX=1 -DHAVE_FONTCONFIG=1 -DWTF_USE_PLUGIN_BACKEND_XLIB=1 -DPLUGIN_ARCHITECTURE_X11=1 -DWTF_USE_3D_GRAPHICS=1 -DWTF_USE_GSTREAMER=1 -DHAVE_SQLITE3=1 -DWTF_USE_GRAPHICS_SURFACE=1 -DWTF_USE_GLX=1 -DENABLE_3D_RENDERING=0 -DENABLE_ACCELERATED_2D_CANVAS=0 -DENABLE_BATTERY_STATUS=0 -DENABLE_BLOB=0 -DENABLE_CANVAS_PATH=0 -DENABLE_CANVAS_PROXY=0 -DENABLE_CHANNEL_MESSAGING=0 -DENABLE_CSP_NEXT=0 -DENABLE_CSS_BOX_DECORATION_BREAK=0 -DENABLE_CSS_COMPOSITING=0 -DENABLE_CSS_EXCLUSIONS=0 -DENABLE_CSS_FILTERS=0 -DENABLE_CSS_GRID_LAYOUT=0 -DENABLE_CSS_HIERARCHIES=0 -DENABLE_CSS_IMAGE_ORIENTATION=0 -DENABLE_CSS_IMAGE_RESOLUTION=0 -DENABLE_CSS_IMAGE_SET=0 -DENABLE_CSS_REGIONS=0 -DENABLE_CSS_SHADERS=0 -DENABLE_CSS_STICKY_POSITION=0 -DENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED=0 -DENABLE_CSS_VARIABLES=0 -DENABLE_CSS3_CONDITIONAL_RULES=0 -DENABLE_CSS3_TEXT=0 -DENABLE_CSS3_TEXT_LINE_BREAK=0 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_DATAGRID=0 -DENABLE_DATALIST_ELEMENT=0 -DENABLE_DATA_TRANSFER_ITEMS=0 -DENABLE_DETAILS_ELEMENT=0 -DENABLE_DEVICE_ORIENTATION=0 -DENABLE_DIRECTORY_UPLOAD=0 -DENABLE_DOWNLOAD_ATTRIBUTE=0 -DENABLE_FILE_SYSTEM=0 -DENABLE_FILTERS=0 -DENABLE_FTPDIR=0 -DENABLE_FULLSCREEN_API=0 -DENABLE_GAMEPAD=0 -DENABLE_GEOLOCATION=0 -DENABLE_HIGH_DPI_CANVAS=0 -DENABLE_ICONDATABASE=0 -DENABLE_IFRAME_SEAMLESS=0 -DENABLE_INDEXED_DATABASE=0 -DENABLE_INPUT_SPEECH=0 -DENABLE_INPUT_TYPE_COLOR=0 -DENABLE_INPUT_TYPE_DATE=0 -DENABLE_INPUT_TYPE_DATETIME=0 -DENABLE_INPUT_TYPE_DATETIMELOCAL=0 -DENABLE_INPUT_TYPE_MONTH=0 -DENABLE_INPUT_TYPE_TIME=0 -DENABLE_INPUT_TYPE_WEEK=0 -DENABLE_INSPECTOR=0 -DENABLE_INSPECTOR_SERVER=0 -DENABLE_JAVASCRIPT_DEBUGGER=0 -DENABLE_LEGACY_CSS_VENDOR_PREFIXES=0 -DENABLE_LEGACY_NOTIFICATIONS=0 -DENABLE_LEGACY_VENDOR_PREFIXES=0 -DENABLE_LEGACY_WEB_AUDIO=0 -DENABLE_LINK_PREFETCH=0 -DENABLE_LINK_PRERENDER=0 -DENABLE_MATHML=0 -DENABLE_MEDIA_SOURCE=0 -DENABLE_MEDIA_STATISTICS=0 -DENABLE_MEDIA_STREAM=0 -DENABLE_METER_ELEMENT=0 -DENABLE_MHTML=0 -DENABLE_MICRODATA=0 -DENABLE_MOUSE_CURSOR_SCALE=0 -DENABLE_NAVIGATOR_CONTENT_UTILS=0 -DENABLE_NETSCAPE_PLUGIN_API=0 -DENABLE_NETWORK_INFO=0 -DENABLE_NOSNIFF=0 -DENABLE_NOTIFICATIONS=0 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_PAGE_VISIBILITY_API=0 -DENABLE_PROGRESS_ELEMENT=0 -DENABLE_PROXIMITY_EVENTS=0 -DENABLE_QUOTA=0 -DENABLE_RESOLUTION_MEDIA_QUERY=0 -DENABLE_REQUEST_ANIMATION_FRAME=0 -DENABLE_SCRIPTED_SPEECH=0 -DENABLE_SHADOW_DOM=0 -DENABLE_SHARED_WORKERS=0 -DENABLE_SMOOTH_SCROLLING=0 -DENABLE_SQL_DATABASE=0 -DENABLE_STYLE_SCOPED=0 -DENABLE_SVG=0 -DENABLE_SVG_DOM_OBJC_BINDINGS=0 -DENABLE_SVG_FONTS=0 -DENABLE_TEXT_AUTOSIZING=0 -DENABLE_TEXT_NOTIFICATIONS_ONLY=0 -DENABLE_TOUCH_EVENTS=0 -DENABLE_TOUCH_ICON_LOADING=0 -DENABLE_VIBRATION=0 -DENABLE_VIDEO=0 -DENABLE_VIDEO_TRACK=0 -DENABLE_WEBGL=0 -DENABLE_WEB_AUDIO=0 -DENABLE_WEB_SOCKETS=0 -DENABLE_WEB_TIMING=0 -DENABLE_WORKERS=0 -DENABLE_XHR_TIMEOUT=0 -DENABLE_XSLT=0 -DSTATICALLY_LINKED_WITH_ANGLE -DSTATICALLY_LINKED_WITH_JavaScriptCore -DWTF_USE_GLIB=1 -DSTATICALLY_LINKED_WITH_WTF -DBUILDING_WebCore -DBUILDING_WEBKIT -DQT_ASCII_CAST_WARNINGS -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG -DQT_SQL_LIB -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I/usr/local/Trolltech/Qt5/Qt-5.0.1/mkspecs/linux-g++ -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/filesystem -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/geolocation -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/indexeddb -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/navigatorcontentutils -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/notifications -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/proximity -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/quota -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/webaudio -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/webdatabase -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/Modules/websockets -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/accessibility -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/generic -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/bridge -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/bridge/qt -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/css -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/dom -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/dom/default -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/editing -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/fileapi -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/history -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/html -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/html/canvas -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/html/parser -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/html/shadow -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/html/track -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/inspector -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/loader -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/loader/appcache -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/loader/archive -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/loader/cache -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/loader/icon -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/mathml -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/page -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/page/animation -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/page/qt -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/page/scrolling -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/page/scrolling/coordinatedgraphics -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/animation -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/audio -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/cpu/arm -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/cpu/arm/filters -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/filters -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/filters/texmap -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/opengl -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/opentype -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/qt -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/surfaces -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/texmap -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/texmap/coordinated -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/transforms -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/image-decoders -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/image-decoders/bmp -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/image-decoders/ico -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/image-decoders/gif -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/image-decoders/jpeg -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/image-decoders/png -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/image-decoders/webp -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/leveldb -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/mock -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/network -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/network/qt -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/qt -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/sql -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/text -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/text/transcoder -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/plugins -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/rendering -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/rendering/mathml -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/rendering/style -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/rendering/svg -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/storage -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/svg -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/svg/animation -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/svg/graphics -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/svg/graphics/filters -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/svg/properties -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/testing -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/websockets -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/workers -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/xml -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/xml/parser -I/ramdisk/qt-linux-release-minimal/build/Source/ThirdParty -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/bridge/jsc -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/js -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/bridge/c -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/testing/js -Igenerated -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/gpu -I/ramdisk/qt-linux-release-minimal/build/Source/WebCore/platform/graphics/gpu -I/ramdisk/qt-linux-release-minimal/build/Source -I/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/include -I/ramdisk/qt-linux-release-minimal/build/Source/ThirdParty/ANGLE/include/GLSLANG -I/ramdisk/qt-linux-release-minimal/build/Source/ThirdParty/ANGLE/include/KHR -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore -I/ramdisk/qt-linux-release-minimal/build/Source -I/ramdisk/qt-linux-release-minimal/build/Source/WTF -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/assembler -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/bytecode -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/bytecompiler -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/heap -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/dfg -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/debugger -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/disassembler -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/interpreter -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/jit -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/llint -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/parser -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/profiler -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/runtime -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/tools -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/yarr -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/API -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/generated -I/ramdisk/qt-linux-release-minimal/build/Source/JavaScriptCore/disassembler/udis86 -I/ramdisk/qt-linux-release-minimal/build/Source/WTF -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/gstreamer-1.0 -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtSql -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtNetwork -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtGui -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtGui/5.0.1 -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtGui/5.0.1/QtGui -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtCore -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtCore/5.0.1 -I/usr/local/Trolltech/Qt5/Qt-5.0.1/include/QtCore/5.0.1/QtCore -I.moc/release-shared -I. -o .obj/release-shared/bindings/js/JSCSSPageRuleCustom.o /ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/js/JSCSSPageRuleCustom.cpp
In file included from generated/JSBlob.h:24:0,
                 from /ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/js/JSBlobCustom.cpp:32:
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/fileapi/Blob.h:54:47: error: 'BlobData' was not declared in this scope
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/fileapi/Blob.h:54:55: error: template argument 1 is invalid
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/fileapi/Blob.h:79:21: error: 'BlobData' was not declared in this scope
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/fileapi/Blob.h:79:29: error: template argument 1 is invalid
In file included from /ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/js/JSBlobCustom.cpp:42:0:
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/fileapi/WebKitBlobBuilder.h:67:5: error: 'BlobDataItemList' does not name a type
Comment 8 Csaba Osztrogonác 2013-03-01 03:41:24 PST
oops, I pasted a useless line too. Sorry.
Comment 9 Alexey Proskuryakov 2013-03-01 10:22:27 PST
I think that I fixed this yesterday in <http://trac.webkit.org/changeset/144372>. Is it still broken?
Comment 10 Zoltan Arvai 2013-03-01 10:28:03 PST
(In reply to comment #9)
> I think that I fixed this yesterday in <http://trac.webkit.org/changeset/144372>. Is it still broken?

Unfortunately, yes, it is still broken: 
http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal?numbuilds=100
Comment 11 Alexey Proskuryakov 2013-03-01 10:47:51 PST
The errors are entirely different though now. OK, I'll see what I can do.
Comment 12 Alexey Proskuryakov 2013-03-01 11:20:19 PST
Attempted fix in <http://trac.webkit.org/changeset/144475>.