Bug 110776 - More style cleanup in GIFImageReader
Summary: More style cleanup in GIFImageReader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hin-Chung Lam
URL:
Keywords:
Depends on:
Blocks: 98098
  Show dependency tree / graph
 
Reported: 2013-02-25 11:36 PST by Hin-Chung Lam
Modified: 2013-02-27 19:11 PST (History)
2 users (show)

See Also:

Attachments
Patch (13.18 KB, patch)
2013-02-25 11:40 PST, Hin-Chung Lam 		allan.jensen: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hin-Chung Lam 2013-02-25 11:36:46 PST 
This include some variables renaming.
Comment 1 Hin-Chung Lam 2013-02-25 11:40:01 PST 
Created attachment 190099 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2013-02-25 12:22:52 PST 
Comment on attachment 190099 [details]
Patch

LGTM
Comment 3 WebKit Review Bot 2013-02-25 17:35:47 PST 
Comment on attachment 190099 [details]
Patch

Rejecting attachment 190099 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 190099, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
d at 657 (offset 35 lines).
Hunk #15 succeeded at 666 (offset 35 lines).
Hunk #16 succeeded at 695 (offset 35 lines).
Hunk #17 succeeded at 762 (offset 36 lines).
Hunk #18 FAILED at 752.
Hunk #19 FAILED at 793.
5 out of 19 hunks FAILED -- saving rejects to file Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Allan Sandfeld Jensen']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16748622
Comment 4 Hin-Chung Lam 2013-02-27 19:11:53 PST 
Committed r144257: <http://trac.webkit.org/changeset/144257>