Bug 110404 - [V8] Rename add{Node,Object}ToGroup() to add{Node,Object}WrapperToGroup()
Summary: [V8] Rename add{Node,Object}ToGroup() to add{Node,Object}WrapperToGroup()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-20 16:18 PST by Kentaro Hara
Modified: 2013-02-21 11:57 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.21 KB, patch)
2013-02-20 16:20 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-20 16:18:21 PST 
The current function name is confusing (See discussion in bug 110396). We should rename the functions so that it becomes clear that "Node"/"Object" refers to a type of a wrapper in the second argument.
Comment 1 Kentaro Hara 2013-02-20 16:20:29 PST 
Created attachment 189404 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-21 11:57:47 PST 
Comment on attachment 189404 [details]
Patch

Clearing flags on attachment: 189404

Committed r143636: <http://trac.webkit.org/changeset/143636>
Comment 3 WebKit Review Bot 2013-02-21 11:57:50 PST 
All reviewed patches have been landed.  Closing bug.