Bug 110233 - HeapBlock::destroy should issue warning if result is unused
Summary: HeapBlock::destroy should issue warning if result is unused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-19 09:39 PST by Mark Hahnenberg
Modified: 2013-02-19 10:41 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2013-02-19 10:22 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-02-19 09:39:01 PST
To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy, we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.
Comment 1 Mark Hahnenberg 2013-02-19 10:22:43 PST
Created attachment 189109 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-19 10:41:48 PST
Comment on attachment 189109 [details]
Patch

Clearing flags on attachment: 189109

Committed r143354: <http://trac.webkit.org/changeset/143354>
Comment 3 WebKit Review Bot 2013-02-19 10:41:50 PST
All reviewed patches have been landed.  Closing bug.