Bug 110228 - WeakSet::removeAllocator leaks WeakBlocks
Summary: WeakSet::removeAllocator leaks WeakBlocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-19 08:58 PST by Mark Hahnenberg
Modified: 2013-02-19 10:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2013-02-19 09:08 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-02-19 08:58:40 PST 
Goodness gracious. We need to return the WeakBlock to the BlockAllocator after the call to WeakBlock::destroy.
Comment 1 Mark Hahnenberg 2013-02-19 09:08:20 PST 
Created attachment 189102 [details]
Patch
Comment 2 Geoffrey Garen 2013-02-19 09:27:16 PST 
Comment on attachment 189102 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2013-02-19 10:13:44 PST 
Comment on attachment 189102 [details]
Patch

Clearing flags on attachment: 189102

Committed r143351: <http://trac.webkit.org/changeset/143351>
Comment 4 WebKit Review Bot 2013-02-19 10:13:47 PST 
All reviewed patches have been landed.  Closing bug.