Bug 110168 - Begin stubbing out session storage classes
Summary: Begin stubbing out session storage classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-18 17:01 PST by Anders Carlsson
Modified: 2013-02-18 17:24 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.52 KB, patch)
2013-02-18 17:02 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-02-18 17:01:56 PST 
Begin stubbing out session storage classes
Comment 1 Anders Carlsson 2013-02-18 17:02:56 PST 
Created attachment 188964 [details]
Patch
Comment 2 Andreas Kling 2013-02-18 17:11:10 PST 
Comment on attachment 188964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188964&action=review

LGTM

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:72
> +    HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageArea>, SecurityOriginHash> m_storageAreaMap;

Can we make a global DefaultHash<RefPtr<SecurityOrigin> > that pulls in SecurityOriginHash?
That could clean up a number of usage sites. Not necessary for this patch.
Comment 3 Anders Carlsson 2013-02-18 17:24:25 PST 
Committed r143277: <http://trac.webkit.org/changeset/143277>