Bug 110008 - We need a CIA replacement
Summary: We need a CIA replacement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-16 03:07 PST by Ryosuke Niwa
Modified: 2013-02-16 13:58 PST (History)
7 users (show)

See Also:

Attachments
Work in progress (4.29 KB, patch)
2013-02-16 03:07 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Work in progress (with actual file) (9.44 KB, patch)
2013-02-16 03:08 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Sample notification (201.21 KB, image/png)
2013-02-16 03:10 PST, Ryosuke Niwa 		no flags Details
Adds new-commit-bot (22.04 KB, patch)
2013-02-16 12:52 PST, Ryosuke Niwa 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-02-16 03:07:38 PST 
I miss CIA.
Comment 1 Ryosuke Niwa 2013-02-16 03:07:54 PST 
Created attachment 188704 [details]
Work in progress
Comment 2 Ryosuke Niwa 2013-02-16 03:08:52 PST 
Created attachment 188705 [details]
Work in progress (with actual file)
Comment 3 Ryosuke Niwa 2013-02-16 03:10:01 PST 
Created attachment 188706 [details]
Sample notification
Comment 4 WebKit Review Bot 2013-02-16 08:46:54 PST 
Attachment 188705 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/Scripts/webkitpy/tool/bot/queueengine.py', u'Tools/Scripts/webkitpy/tool/commands/__init__.py', u'Tools/Scripts/webkitpy/tool/commands/newcommitbot.py', u'Tools/Scripts/webkitpy/tool/commands/queues.py', u'Tools/Scripts/webkitpy/tool/main.py']" exit_code: 1
Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:60:  at least two spaces before inline comment  [pep8/E261] [5]
Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:102:  missing whitespace around operator  [pep8/E225] [5]
Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:107:  [NewCommitBot._find_changesets] Method has no argument  [pylint/E0211] [5]
Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:111:  [NewCommitBot.handle_unexpected_error] Undefined variable '_log'  [pylint/E0602] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Ryosuke Niwa 2013-02-16 12:52:40 PST 
Created attachment 188724 [details]
Adds new-commit-bot
Comment 6 Andreas Kling 2013-02-16 13:33:34 PST 
Comment on attachment 188724 [details]
Adds new-commit-bot

<3!
Comment 7 Ryosuke Niwa 2013-02-16 13:58:49 PST 
Committed r143109: <http://trac.webkit.org/changeset/143109>