Bug 109914 - [CSS Regions] Assertion in RenderFlowThread::removeRenderBoxRegionInfo
Summary: [CSS Regions] Assertion in RenderFlowThread::removeRenderBoxRegionInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2013-02-15 02:06 PST by Andrei Bucur
Modified: 2013-02-19 05:46 PST (History)
4 users (show)

See Also:


Attachments
Test that crashes (656 bytes, text/html)
2013-02-15 02:06 PST, Andrei Bucur
no flags Details
Test that crashes v2 (658 bytes, text/html)
2013-02-15 04:05 PST, Andrei Bucur
no flags Details
Patch (8.61 KB, patch)
2013-02-15 06:48 PST, Andrei Bucur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2013-02-15 02:06:32 PST
Created attachment 188516 [details]
Test that crashes

It is possible to remove a box from a flow thread right after deleting a region from the chain. Without a layout to rebuild the region ranges for the box, an assertion is hit because some regions still have information about the box.
See the test case attached.
Comment 1 Andrei Bucur 2013-02-15 04:05:27 PST
Created attachment 188532 [details]
Test that crashes v2

The previous test didn't trigger the assert.
Comment 2 Andrei Bucur 2013-02-15 06:48:16 PST
Created attachment 188556 [details]
Patch
Comment 3 Dave Hyatt 2013-02-18 17:59:09 PST
Comment on attachment 188556 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2013-02-19 01:18:20 PST
Comment on attachment 188556 [details]
Patch

Rejecting attachment 188556 [details] from commit-queue.

abucur@adobe.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Review Bot 2013-02-19 05:46:24 PST
Comment on attachment 188556 [details]
Patch

Clearing flags on attachment: 188556

Committed r143322: <http://trac.webkit.org/changeset/143322>
Comment 6 WebKit Review Bot 2013-02-19 05:46:27 PST
All reviewed patches have been landed.  Closing bug.