Bug 109840 - [Mac] adjust caption color user preference calculation
Summary: [Mac] adjust caption color user preference calculation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-14 09:10 PST by Eric Carlson
Modified: 2013-02-14 13:55 PST (History)
2 users (show)

See Also:

Attachments
Proposed patch (21.02 KB, text/plain)
2013-02-14 09:16 PST, Eric Carlson 		no flags Details
Proposed patch (3.67 KB, patch)
2013-02-14 09:33 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-02-14 09:10:00 PST 
Mark user caption color overrides as "!important" if either the color or opacity do not allow overrides.
Comment 1 Eric Carlson 2013-02-14 09:16:42 PST 
Created attachment 188369 [details]
Proposed patch
Comment 2 Eric Carlson 2013-02-14 09:17:06 PST 
<rdar://problem/13201278>
Comment 3 WebKit Review Bot 2013-02-14 09:19:37 PST 
Attachment 188369 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2013-02-14 09:33:42 PST 
Created attachment 188371 [details]
Proposed patch
Comment 5 Eric Carlson 2013-02-14 13:55:52 PST 
Committed in http://trac.webkit.org/r142910.