Bug 109747 - [Mac] Clean up WARNING_CFLAGS
Summary: [Mac] Clean up WARNING_CFLAGS
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on:
Reported: 2013-02-13 14:05 PST by David Kilzer (:ddkilzer)
Modified: 2013-02-14 13:18 PST (History)
5 users (show)

See Also:

Patch v1 (14.10 KB, patch)
2013-02-13 14:14 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (13.64 KB, patch)
2013-02-13 14:37 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v3 (14.23 KB, patch)
2013-02-14 11:37 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-02-13 14:05:45 PST
* Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.
Comment 1 David Kilzer (:ddkilzer) 2013-02-13 14:14:18 PST
Created attachment 188180 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2013-02-13 14:37:01 PST
Created attachment 188185 [details]
Patch v2

Turn off -Wshorten-64-to-32 for WebKit and WebKit2.  They weren't on before.
Comment 3 David Kilzer (:ddkilzer) 2013-02-13 15:48:22 PST
Comment 4 David Kilzer (:ddkilzer) 2013-02-14 11:37:03 PST
Created attachment 188390 [details]
Patch v3

Add back FIXME comments with bugs\!
Comment 5 WebKit Review Bot 2013-02-14 13:18:27 PST
Comment on attachment 188390 [details]
Patch v3

Clearing flags on attachment: 188390

Committed r142903: <http://trac.webkit.org/changeset/142903>
Comment 6 WebKit Review Bot 2013-02-14 13:18:31 PST
All reviewed patches have been landed.  Closing bug.