RESOLVED FIXED 109747
[Mac] Clean up WARNING_CFLAGS 
https://bugs.webkit.org/show_bug.cgi?id=109747
Summary [Mac] Clean up WARNING_CFLAGS
David Kilzer (:ddkilzer)
Reported 2013-02-13 14:05:45 PST
* Configurations/Base.xcconfig: Use GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable -Wshorten-64-to-32 rather than WARNING_CFLAGS.
Attachments
Patch v1 (14.10 KB, patch)
2013-02-13 14:14 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (13.64 KB, patch)
2013-02-13 14:37 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v3 (14.23 KB, patch)
2013-02-14 11:37 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2013-02-13 14:14:18 PST
Created attachment 188180 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2013-02-13 14:37:01 PST
Created attachment 188185 [details] Patch v2 Turn off -Wshorten-64-to-32 for WebKit and WebKit2. They weren't on before.
David Kilzer (:ddkilzer)
Comment 3 2013-02-13 15:48:22 PST
<rdar://problem/13208373>
David Kilzer (:ddkilzer)
Comment 4 2013-02-14 11:37:03 PST
Created attachment 188390 [details] Patch v3 Add back FIXME comments with bugs\!
WebKit Review Bot
Comment 5 2013-02-14 13:18:27 PST
Comment on attachment 188390 [details] Patch v3 Clearing flags on attachment: 188390 Committed r142903: <http://trac.webkit.org/changeset/142903>
WebKit Review Bot
Comment 6 2013-02-14 13:18:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.