Bug 109713 – [CSS Exclusions] Enable shape-inside support for circles

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hans Muller]

Enable shape-inside support for shapes specified with the circle function.

[Hans Muller]

Created attachment 188379 [details]
Patch

Using the EWS to verify that supixel layout differences don't  have an impact on the new test.

[Dirk Schulze]

Comment on attachment 188379 [details]
Patch

LGTM. r=me.

[WebKit Review Bot]

Comment on attachment 188379 [details]
Patch

Clearing flags on attachment: 188379

Committed r143010: <http://trac.webkit.org/changeset/143010>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

It seems like this patch caused 16+ patches to crash on ML2 test bots?

http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/6075

[Dirk Schulze]

(In reply to comment #5)
> It seems like this patch caused 16+ patches to crash on ML2 test bots?
> 
> http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/6075

Are you sure that this is this patch causing the errors?

Here is a list of the failing tests:

Regressions: Unexpected crashes (15)
  accessibility/accessibility-node-memory-management.html [ Crash ]
  accessibility/accessibility-node-reparent.html [ Crash ]
  animations/3d/matrix-transform-type-animation.html [ Crash ]
  animations/additive-transform-animations.html [ Crash ]
  animations/animation-add-events-in-handler.html [ Crash ]
  animations/animation-border-overflow.html [ Crash ]
  animations/animation-controller-drt-api.html [ Crash ]
  animations/animation-css-rule-types.html [ Crash ]
  canvas/philip/tests/2d.canvas.reference.html [ Crash ]
  canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html [ Crash ]
  compositing/absolute-inside-out-of-view-fixed.html [ Crash ]
  compositing/absolute-position-changed-in-composited-layer.html [ Crash ]
  compositing/video/video-poster.html [ Crash ]
  http/tests/cache/cached-main-resource.html [ Crash ]
  media/video-controls-captions-trackmenu.html [ Crash ]

I did not investigate yet, but a big chunk (all?) of the tests is independent of layout code that was touched by this patch.

[Hans Muller]

*** Bug 96670 has been marked as a duplicate of this bug. ***