Bug 109586 - Remove remaining traces of Web Intents
Summary: Remove remaining traces of Web Intents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 109501
  Show dependency tree / graph
 
Reported: 2013-02-12 07:48 PST by Chris Dumez
Modified: 2013-02-12 13:23 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.85 KB, patch)
2013-02-12 07:58 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-02-12 07:48:46 PST 
There are still traces of Web Intents, especially in build system related files.
Comment 1 Chris Dumez 2013-02-12 07:58:55 PST 
Created attachment 187868 [details]
Patch
Comment 2 Nico Weber 2013-02-12 09:02:35 PST 
Comment on attachment 187868 [details]
Patch

Thanks! I used a whitelist of file extensions when doing `git grep`, which in hindsight wasn't a great idea.

Without the whitelist, I see there's another use in Source/WebCore/UseJSC.cmake – can you remove that too?
Comment 3 Nico Weber 2013-02-12 10:28:35 PST 
(In reply to comment #2)
> (From update of attachment 187868 [details])
> Thanks! I used a whitelist of file extensions when doing `git grep`, which in hindsight wasn't a great idea.
> 
> Without the whitelist, I see there's another use in Source/WebCore/UseJSC.cmake – can you remove that too?

…nevermind, that already got removed in r142570.
Comment 4 WebKit Review Bot 2013-02-12 13:23:10 PST 
Comment on attachment 187868 [details]
Patch

Clearing flags on attachment: 187868

Committed r142664: <http://trac.webkit.org/changeset/142664>
Comment 5 WebKit Review Bot 2013-02-12 13:23:15 PST 
All reviewed patches have been landed.  Closing bug.