Bug 109217 - WebKit does not build when compiling with css3-text and css3-conditional-rules feature flags enabled.
Summary: WebKit does not build when compiling with css3-text and css3-conditional-rule...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 12:36 PST by Lamarque V. Souza
Modified: 2013-02-07 16:19 PST (History)
5 users (show)

See Also:

Attachments
Fix build with css3-text and css3-conditiona-rules (1.23 KB, patch)
2013-02-07 12:36 PST, Lamarque V. Souza 		no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2013-02-07 12:47 PST, Lamarque V. Souza 		no flags Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2013-02-07 15:14 PST, Lamarque V. Souza 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lamarque V. Souza 2013-02-07 12:36:39 PST 
Created attachment 187148 [details]
Fix build with css3-text and css3-conditiona-rules

Because of some changes in commits 78f751a31aa2a23acb4dfc03768821934accff7e and 686b13346a97e637edc3ec071ea7ce1a607649c7 WebKit does not build with css3-text and css3-conditional-rules anymore. The attached patch fixes the problems I have found.
Comment 1 Lamarque V. Souza 2013-02-07 12:47:34 PST 
Created attachment 187151 [details]
Patch

Proposed patch
Comment 2 Lamarque V. Souza 2013-02-07 15:14:28 PST 
Created attachment 187185 [details]
Patch

Proposed patch
Comment 3 WebKit Review Bot 2013-02-07 16:19:50 PST 
Comment on attachment 187185 [details]
Patch

Clearing flags on attachment: 187185

Committed r142199: <http://trac.webkit.org/changeset/142199>
Comment 4 WebKit Review Bot 2013-02-07 16:19:53 PST 
All reviewed patches have been landed.  Closing bug.