Bug 109174 - Web Inspector: [Regression] Map.size() returns negative values.
Summary: Web Inspector: [Regression] Map.size() returns negative values.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 04:11 PST by Vsevolod Vlasov
Modified: 2013-02-12 13:21 PST (History)
9 users (show)

See Also:


Attachments
Patch (4.77 KB, patch)
2013-02-07 04:12 PST, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (4.77 KB, patch)
2013-02-07 04:18 PST, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2013-02-07 04:11:38 PST
Patch to follow
Comment 1 Vsevolod Vlasov 2013-02-07 04:12:53 PST
Created attachment 187056 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-02-07 04:18:50 PST
Created attachment 187058 [details]
Patch
Comment 3 WebKit Review Bot 2013-02-07 08:31:57 PST
Comment on attachment 187058 [details]
Patch

Clearing flags on attachment: 187058

Committed r142128: <http://trac.webkit.org/changeset/142128>
Comment 4 WebKit Review Bot 2013-02-07 08:32:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Pavel Feldman 2013-02-12 13:06:37 PST
Comment on attachment 187058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187058&action=review

> Source/WebCore/inspector/front-end/utilities.js:727
> +        if (!result)

Are you saying we do not allow storing "null", empty string, etc as values?
Comment 6 Pavel Feldman 2013-02-12 13:21:44 PST
Comment on attachment 187058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187058&action=review

>> Source/WebCore/inspector/front-end/utilities.js:727
>> +        if (!result)
> 
> Are you saying we do not allow storing "null", empty string, etc as values?

Ignore me, now I see that you store pairs as values.