Bug 109043 - [chromium] move methods that change initial testRunner state to TestRunner library
Summary: [chromium] move methods that change initial testRunner state to TestRunner li...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 91308
  Show dependency tree / graph
 
Reported: 2013-02-06 05:32 PST by jochen
Modified: 2013-02-09 10:57 PST (History)
6 users (show)

See Also:

Attachments
Patch (10.67 KB, patch)
2013-02-08 12:30 PST, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-02-06 05:32:08 PST 
Depending on the name of the layout test, we change certain parameters, e.g. dumpAsText()

This logic should be part of the TestRunner library
Comment 1 jochen 2013-02-08 12:30:03 PST 
Created attachment 187349 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-08 12:31:20 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2013-02-08 21:12:47 PST 
Comment on attachment 187349 [details]
Patch

This patches are great.
Comment 4 WebKit Review Bot 2013-02-09 10:57:13 PST 
Comment on attachment 187349 [details]
Patch

Clearing flags on attachment: 187349

Committed r142370: <http://trac.webkit.org/changeset/142370>
Comment 5 WebKit Review Bot 2013-02-09 10:57:16 PST 
All reviewed patches have been landed.  Closing bug.