Bug 109014 – REGRESSION(r141964): caused performance regression (Requested by hayato on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/141964 broke the build:
caused performance regression (Requested by hayato on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 186770 [details]
ROLLOUT of r141964

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Hayato Ito]

It seems that the patch caused a performance regression.

Let me paste URLs rniwa game me in #webkit.

http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/intl2/report.html?history=150&rev=-1

http://webkit-perf.appspot.com/graph.html#tests=[[3395411,2001,3001],[3395402,2001,3001],[3630247,2001,3001]]&sel=1360097136438.8433,1360136808728,328.6474501108647,364.56762749445676&displayrange=7&datatype=running


The patch should be just a factoring and should not cause any regression.
Let me revert it at first. Then let me investigate the cause without any pressure.

[WebKit Review Bot]

Comment on attachment 186770 [details]
ROLLOUT of r141964

Clearing flags on attachment: 186770

Committed r141973: <http://trac.webkit.org/changeset/141973>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.