Bug 108994 - [Mac] Complete plumbing so captions menu can indicate track type
Summary: [Mac] Complete plumbing so captions menu can indicate track type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-05 17:42 PST by Eric Carlson
Modified: 2019-05-13 15:14 PDT (History)
14 users (show)

See Also:


Attachments
Proposed patch (9.79 KB, patch)
2013-02-05 18:01 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-02-05 17:42:53 PST
Plumb the  <type-indicator> added in http://trac.webkit.org/changeset/141864 through to the AVFoundation media engine.
Comment 1 Radar WebKit Bug Importer 2013-02-05 17:43:21 PST
<rdar://problem/13159126>
Comment 2 Eric Carlson 2013-02-05 18:01:58 PST
Created attachment 186735 [details]
Proposed patch
Comment 3 Dean Jackson 2013-02-05 18:13:20 PST
Comment on attachment 186735 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186735&action=review

> LayoutTests/ChangeLog:8
> +        Update test results now that the Mac media engine identified CC tracks.

I didn't spot the typo here, but you mentioned it and I wanted to look smart.
Comment 4 Eric Carlson 2013-02-05 18:17:28 PST
Committed r141957: <http://trac.webkit.org/changeset/141957>