Bug 108706 - Dashboard cleanup: Make builder a real dashboardSpecificParameter.
Summary: Dashboard cleanup: Make builder a real dashboardSpecificParameter.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-01 15:12 PST by Julie Parent
Modified: 2013-02-04 17:48 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.98 KB, patch)
2013-02-01 15:16 PST, Julie Parent 		no flags Details | Formatted Diff | Diff
Patch for landing (9.02 KB, patch)
2013-02-04 16:57 PST, Julie Parent 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2013-02-01 15:12:52 PST 
Dashboard cleanup: Make builder a real dashboardSpecificParameter.
Comment 1 Julie Parent 2013-02-01 15:16:56 PST 
Created attachment 186158 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-04 15:31:21 PST 
Comment on attachment 186158 [details]
Patch

Rejecting attachment 186158 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 186158, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16378300
Comment 3 Julie Parent 2013-02-04 16:57:36 PST 
Created attachment 186499 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-02-04 17:48:17 PST 
Comment on attachment 186499 [details]
Patch for landing

Clearing flags on attachment: 186499

Committed r141839: <http://trac.webkit.org/changeset/141839>
Comment 5 WebKit Review Bot 2013-02-04 17:48:20 PST 
All reviewed patches have been landed.  Closing bug.