Bug 107957 - [BlackBerry] Pop-up WebViews should not take ownership of the backing store.
Summary: [BlackBerry] Pop-up WebViews should not take ownership of the backing store.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 09:40 PST by Andrew Lo
Modified: 2013-01-25 11:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.78 KB, patch)
2013-01-25 09:47 PST, Andrew Lo 		no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2013-01-25 10:41 PST, Andrew Lo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2013-01-25 09:40:37 PST 
WebViews that are set as pop-up WebViews should not take ownership of the backing store.
Need a web setting to enable/disable that.
Comment 1 Andrew Lo 2013-01-25 09:47:42 PST 
Created attachment 184765 [details]
Patch
Comment 2 Rob Buis 2013-01-25 09:50:34 PST 
Comment on attachment 184765 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-01-25 09:53:10 PST 
Comment on attachment 184765 [details]
Patch

Rejecting attachment 184765 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 184765, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
urce/WebKit/blackberry/Api/WebSettings.h
patching file Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp
Hunk #1 FAILED at 39.
Hunk #2 succeeded at 52 (offset 1 line).
Hunk #3 succeeded at 67 (offset 1 line).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16121440
Comment 4 Andrew Lo 2013-01-25 10:41:57 PST 
Created attachment 184774 [details]
Patch
Comment 5 Rob Buis 2013-01-25 10:45:52 PST 
Comment on attachment 184774 [details]
Patch

Ok.
Comment 6 WebKit Review Bot 2013-01-25 11:02:07 PST 
Comment on attachment 184774 [details]
Patch

Clearing flags on attachment: 184774

Committed r140849: <http://trac.webkit.org/changeset/140849>
Comment 7 WebKit Review Bot 2013-01-25 11:02:11 PST 
All reviewed patches have been landed.  Closing bug.