Bug 107900 - Keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize() for MessageEvent
: Keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize() ...
Status: RESOLVED FIXED
: WebKit
WebCore JavaScript
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2013-01-24 20:00 PST by
Modified: 2013-01-25 21:29 PST (History)


Attachments
Patch (4.29 KB, patch)
2013-01-24 20:02 PST, Kentaro Hara
no flags Review Patch | Details | Formatted Diff | Diff
Patch (4.28 KB, patch)
2013-01-24 20:33 PST, Kentaro Hara
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2013-01-24 20:00:21 PST
If you use a raw SerializedScriptValue* for serialize()/deserialize(), it can potentially cause a use-after-free. This is because serialize()/deserialize() can destruct a RefPtr of the SerializedScriptValue*, depending on data that is serialized/deserialized. So we should keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize(). (See https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)
------- Comment #1 From 2013-01-24 20:02:08 PST -------
Created an attachment (id=184642) [details]
Patch
------- Comment #2 From 2013-01-24 20:33:18 PST -------
Created an attachment (id=184646) [details]
Patch
------- Comment #3 From 2013-01-24 21:16:07 PST -------
(From update of attachment 184646 [details])
Rejecting attachment 184646 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184646, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
webkit-commit-queue

Parsed 4 diffs from patch file(s).
patch: **** Can't create file /tmp/ppXGuTHe : No space left on device
patch: **** Can't create file /tmp/ppXchdli : No space left on device
patch: **** Can't create file /tmp/ppJlfgAi : No space left on device
patch: **** Can't create file /tmp/pplJ1oci : No space left on device

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Abhishek Arya']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16117110
------- Comment #4 From 2013-01-24 21:56:57 PST -------
(From update of attachment 184646 [details])
Rejecting attachment 184646 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184646, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
webkit-commit-queue

Parsed 4 diffs from patch file(s).
patch: **** Can't create file /tmp/pp3TdUNN : No space left on device
patch: **** Can't create file /tmp/ppRGbzuO : No space left on device
patch: **** Can't create file /tmp/ppfZ7J6N : No space left on device
patch: **** Can't create file /tmp/pp7cK7zM : No space left on device

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Abhishek Arya']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16112298
------- Comment #5 From 2013-01-25 17:38:09 PST -------
(From update of attachment 184646 [details])
Clearing flags on attachment: 184646

Committed r140891: <http://trac.webkit.org/changeset/140891>
------- Comment #6 From 2013-01-25 17:38:13 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #7 From 2013-01-25 21:29:25 PST -------
Build break is fixed on EFL WK2 - http://trac.webkit.org/changeset/140902