Bug 107828 - Web Inspector: Move dispatchMouseEvent optional params after x,y
Summary: Web Inspector: Move dispatchMouseEvent optional params after x,y
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ken Kania
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 08:07 PST by Ken Kania
Modified: 2013-01-25 05:12 PST (History)
9 users (show)

See Also:


Attachments
Patch (5.16 KB, patch)
2013-01-24 08:11 PST, Ken Kania
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Kania 2013-01-24 08:07:15 PST
In r140649 we moved the timestamp/modifiers params to be before x,y to match dispatchKeyEvent. That makes JSCompiler produce warning because optional args should be after non-optional ones. Moving these back to their original place...
Comment 1 Ken Kania 2013-01-24 08:11:25 PST
Created attachment 184501 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-24 08:59:46 PST
Comment on attachment 184501 [details]
Patch

Rejecting attachment 184501 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184501, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
webkit-commit-queue

Parsed 4 diffs from patch file(s).
patch: **** Can't create file /tmp/ppTVTENi : No space left on device
patch: **** Can't create file /tmp/ppDCvFCj : No space left on device
patch: **** Can't create file /tmp/ppJyO4ij : No space left on device
patch: **** Can't create file /tmp/pppOsUwj : No space left on device

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16073854
Comment 3 WebKit Review Bot 2013-01-25 05:12:10 PST
Comment on attachment 184501 [details]
Patch

Clearing flags on attachment: 184501

Committed r140818: <http://trac.webkit.org/changeset/140818>
Comment 4 WebKit Review Bot 2013-01-25 05:12:13 PST
All reviewed patches have been landed.  Closing bug.