RESOLVED FIXED 107828
Web Inspector: Move dispatchMouseEvent optional params after x,y 
https://bugs.webkit.org/show_bug.cgi?id=107828
Summary Web Inspector: Move dispatchMouseEvent optional params after x,y
Ken Kania
Reported 2013-01-24 08:07:15 PST
In r140649 we moved the timestamp/modifiers params to be before x,y to match dispatchKeyEvent. That makes JSCompiler produce warning because optional args should be after non-optional ones. Moving these back to their original place...
Attachments
Patch (5.16 KB, patch)
2013-01-24 08:11 PST, Ken Kania 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ken Kania
Comment 1 2013-01-24 08:11:25 PST
Created attachment 184501 [details] Patch
WebKit Review Bot
Comment 2 2013-01-24 08:59:46 PST
Comment on attachment 184501 [details] Patch Rejecting attachment 184501 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184501, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: webkit-commit-queue Parsed 4 diffs from patch file(s). patch: **** Can't create file /tmp/ppTVTENi : No space left on device patch: **** Can't create file /tmp/ppDCvFCj : No space left on device patch: **** Can't create file /tmp/ppJyO4ij : No space left on device patch: **** Can't create file /tmp/pppOsUwj : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16073854
WebKit Review Bot
Comment 3 2013-01-25 05:12:10 PST
Comment on attachment 184501 [details] Patch Clearing flags on attachment: 184501 Committed r140818: <http://trac.webkit.org/changeset/140818>
WebKit Review Bot
Comment 4 2013-01-25 05:12:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.