Bug 107756 - Don't allocate rare data on every Element on removal
Summary: Don't allocate rare data on every Element on removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 16:27 PST by Elliott Sprehn
Modified: 2013-01-23 20:07 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2013-01-23 16:29 PST, Elliott Sprehn
no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2013-01-23 16:30 PST, Elliott Sprehn
no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2013-01-23 16:38 PST, Elliott Sprehn
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2013-01-23 16:27:40 PST
Don't allocate rare data on every Element won removal
Comment 1 Elliott Sprehn 2013-01-23 16:29:59 PST
Created attachment 184339 [details]
Patch
Comment 2 Elliott Sprehn 2013-01-23 16:30:53 PST
Created attachment 184340 [details]
Patch
Comment 3 Elliott Sprehn 2013-01-23 16:38:38 PST
Created attachment 184343 [details]
Patch
Comment 4 Eric Seidel (no email) 2013-01-23 16:49:02 PST
Comment on attachment 184343 [details]
Patch

!!  Do we have any ways to detect rare-data thrash?
Comment 5 Elliott Sprehn 2013-01-23 17:02:25 PST
(In reply to comment #4)
> (From update of attachment 184343 [details])
> !!  Do we have any ways to detect rare-data thrash?

Apparently not, we should figure out some way to detect this.
Comment 6 WebKit Review Bot 2013-01-23 20:07:51 PST
Comment on attachment 184343 [details]
Patch

Clearing flags on attachment: 184343

Committed r140638: <http://trac.webkit.org/changeset/140638>
Comment 7 WebKit Review Bot 2013-01-23 20:07:55 PST
All reviewed patches have been landed.  Closing bug.