Bug 107711 - IndexedDB: Remove IDBVersionChangeRequest
Summary: IndexedDB: Remove IDBVersionChangeRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on: 108045
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-23 11:45 PST by Joshua Bell
Modified: 2013-01-28 16:23 PST (History)
12 users (show)

See Also:


Attachments
Patch (44.80 KB, patch)
2013-01-23 12:03 PST, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2013-01-23 11:45:35 PST
IndexedDB: Remove IDBVersionChangeRequest
Comment 1 Joshua Bell 2013-01-23 12:03:42 PST
Created attachment 184275 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-23 12:06:10 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Joshua Bell 2013-01-23 12:06:40 PST
abarth@ - rubber stamp for deleting code from WebKit/chromium/ ?

tony@ - review?
Comment 4 Adam Barth 2013-01-23 12:18:48 PST
Comment on attachment 184275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184275&action=review

> Source/WebKit/chromium/public/WebIDBCallbacks.h:60
> +    // FIXME: Remove the following overload once callers are updated:

API change LGTM
Comment 5 WebKit Review Bot 2013-01-23 14:59:50 PST
Comment on attachment 184275 [details]
Patch

Clearing flags on attachment: 184275

Committed r140602: <http://trac.webkit.org/changeset/140602>
Comment 6 WebKit Review Bot 2013-01-23 14:59:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2013-01-27 19:03:51 PST
Re-opened since this is blocked by bug 108045
Comment 8 Joshua Bell 2013-01-28 16:23:32 PST
Relanded as http://trac.webkit.org/changeset/141013