Bug 107663 - [V8] Make an Isolate parameter mandatory in NativeToJS()
Summary: [V8] Make an Isolate parameter mandatory in NativeToJS()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 04:26 PST by Kentaro Hara
Modified: 2013-01-23 18:12 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.56 KB, patch)
2013-01-23 04:27 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-23 04:26:32 PST
[V8] Make an Isolate parameter mandatory in NativeToJS().
Comment 1 Kentaro Hara 2013-01-23 04:27:36 PST
Created attachment 184200 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-23 16:36:05 PST
Comment on attachment 184200 [details]
Patch

Rejecting attachment 184200 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 184200, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 167605 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
55>At revision 167605.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/16074450
Comment 3 WebKit Review Bot 2013-01-23 18:12:47 PST
Comment on attachment 184200 [details]
Patch

Clearing flags on attachment: 184200

Committed r140624: <http://trac.webkit.org/changeset/140624>
Comment 4 WebKit Review Bot 2013-01-23 18:12:50 PST
All reviewed patches have been landed.  Closing bug.