Bug 107457 - [GTK] Implement resources API using injected bundle
Summary: [GTK] Implement resources API using injected bundle
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 107456
  Show dependency treegraph
Reported: 2013-01-21 08:22 PST by Gustavo Noronha (kov)
Modified: 2013-01-29 04:03 PST (History)
5 users (show)

See Also:

Patch (26.63 KB, patch)
2013-01-27 03:51 PST, Carlos Garcia Campos
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2013-01-21 08:22:16 PST
The ResourceLoaderClient has been removed from WebKit2 in http://trac.webkit.org/changeset/140285 and its implementation has been removed from WebKit2GTK+ in http://trac.webkit.org/changeset/140337
Comment 1 Gustavo Noronha (kov) 2013-01-21 08:53:48 PST
This also makes a bunch of tests that use WebResource fail:

Tests that timed out (14): /WebKit2APITests/TestWebKitWebContext, /WebKit2APITests/TestWebViewEditor, /WebKit2APITests/TestWebExtensions, /WebKit2APITests/TestInspector, /WebKit2APITests/TestWebKitSettings, /WebKit2APITests/TestBackForwardList, /WebKit2APITests/TestWebKitWebView, /WebKit2APITests/TestWebKitPolicyClient, /WebKit2APITests/TestPrinting, /WebKit2APITests/TestLoaderClient, /WebKit2APITests/TestCookieManager, /WebKit2APITests/TestSSL, /WebKit2APITests/TestContextMenu, /WebKit2APITests/TestWebKitFindController
Comment 2 Carlos Garcia Campos 2013-01-22 00:34:42 PST
This will take a while to reimplement, I'll try to find the time . . .
Comment 3 Carlos Garcia Campos 2013-01-27 03:51:37 PST
Created attachment 184910 [details]
Comment 4 WebKit Review Bot 2013-01-27 03:54:05 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 Martin Robinson 2013-01-28 20:54:20 PST
FWIW, this looks good to me as well.
Comment 6 Carlos Garcia Campos 2013-01-29 04:03:24 PST
Committed r141096: <http://trac.webkit.org/changeset/141096>