WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107355
Remove PLATFORM(TORCHMOBILE) from Assertions.h
https://bugs.webkit.org/show_bug.cgi?id=107355
Summary
Remove PLATFORM(TORCHMOBILE) from Assertions.h
Laszlo Gombos
Reported
2013-01-18 20:45:46 PST
This appears to be the only PLATFORM(TORCHMOBILE) ifdef. I don't believe this ifdef is needed anymore.
Attachments
proposed changed
(1.11 KB, patch)
2013-01-18 20:50 PST
,
Laszlo Gombos
eric
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
for cq
(1.14 KB, patch)
2013-01-18 21:37 PST
,
Laszlo Gombos
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2013-01-18 20:50:06 PST
Created
attachment 183598
[details]
proposed changed Similar cleanup at
r111251
.
Eric Seidel (no email)
Comment 2
2013-01-18 21:10:01 PST
Comment on
attachment 183598
[details]
proposed changed LGTM.
WebKit Review Bot
Comment 3
2013-01-18 21:12:45 PST
Comment on
attachment 183598
[details]
proposed changed Rejecting
attachment 183598
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/15976030
Laszlo Gombos
Comment 4
2013-01-18 21:37:07 PST
Created
attachment 183602
[details]
for cq
WebKit Review Bot
Comment 5
2013-01-18 22:21:35 PST
Comment on
attachment 183602
[details]
for cq Clearing flags on attachment: 183602 Committed
r140236
: <
http://trac.webkit.org/changeset/140236
>
WebKit Review Bot
Comment 6
2013-01-18 22:21:39 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug