Bug 107355 - Remove PLATFORM(TORCHMOBILE) from Assertions.h
Summary: Remove PLATFORM(TORCHMOBILE) from Assertions.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-18 20:45 PST by Laszlo Gombos
Modified: 2013-01-19 06:24 PST (History)
7 users (show)

See Also:

Attachments
proposed changed (1.11 KB, patch)
2013-01-18 20:50 PST, Laszlo Gombos 		eric: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
for cq (1.14 KB, patch)
2013-01-18 21:37 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-01-18 20:45:46 PST 
This appears to be the only PLATFORM(TORCHMOBILE) ifdef. I don't believe this ifdef is needed anymore.
Comment 1 Laszlo Gombos 2013-01-18 20:50:06 PST 
Created attachment 183598 [details]
proposed changed

Similar cleanup at r111251.
Comment 2 Eric Seidel (no email) 2013-01-18 21:10:01 PST 
Comment on attachment 183598 [details]
proposed changed

LGTM.
Comment 3 WebKit Review Bot 2013-01-18 21:12:45 PST 
Comment on attachment 183598 [details]
proposed changed

Rejecting attachment 183598 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15976030
Comment 4 Laszlo Gombos 2013-01-18 21:37:07 PST 
Created attachment 183602 [details]
for cq
Comment 5 WebKit Review Bot 2013-01-18 22:21:35 PST 
Comment on attachment 183602 [details]
for cq

Clearing flags on attachment: 183602

Committed r140236: <http://trac.webkit.org/changeset/140236>
Comment 6 WebKit Review Bot 2013-01-18 22:21:39 PST 
All reviewed patches have been landed.  Closing bug.