Bug 106962 - GCE build scripts don't take working directory into account when calling findzone.sh
Summary: GCE build scripts don't take working directory into account when calling find...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alan Cutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 17:05 PST by Alan Cutter
Modified: 2013-01-16 20:01 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2013-01-15 17:11 PST, Alan Cutter 		no flags Details | Formatted Diff | Diff
Patch (4.74 KB, patch)
2013-01-16 18:59 PST, Alan Cutter 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Cutter 2013-01-15 17:05:57 PST 
You cannot start the build scripts in a directory other than the one they're located in.
Comment 1 Alan Cutter 2013-01-15 17:11:20 PST 
Created attachment 182879 [details]
Patch
Comment 2 Adam Barth 2013-01-16 16:46:01 PST 
Comment on attachment 182879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182879&action=review

> Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh:38
> +

I'd skip this blank line.
Comment 3 Alan Cutter 2013-01-16 18:59:10 PST 
Created attachment 183093 [details]
Patch
Comment 4 Alan Cutter 2013-01-16 18:59:50 PST 
(In reply to comment #2)
> (From update of attachment 182879 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182879&action=review
> 
> > Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh:38
> > +
> 
> I'd skip this blank line.

Removed blank line.
Comment 5 WebKit Review Bot 2013-01-16 20:01:31 PST 
Comment on attachment 183093 [details]
Patch

Clearing flags on attachment: 183093

Committed r139957: <http://trac.webkit.org/changeset/139957>
Comment 6 WebKit Review Bot 2013-01-16 20:01:35 PST 
All reviewed patches have been landed.  Closing bug.