WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106917
[GTK] Fix build error on GTK due to
r139665
https://bugs.webkit.org/show_bug.cgi?id=106917
Summary
[GTK] Fix build error on GTK due to r139665
Michael Pruett
Reported
2013-01-15 09:52:20 PST
Commit <
http://svn.webkit.org/repository/webkit/trunk@139665
> added the new files VariablePacker.cpp and VariablePacker.h but failed to add these files to Source/WebCore/GNUmakefile.list.am. WebKitGTK+ currently fails to build due to this omission.
Attachments
Patch
(929 bytes, patch)
2013-01-15 09:55 PST
,
Michael Pruett
no flags
Details
Formatted Diff
Diff
Patch
(1.47 KB, patch)
2013-01-15 09:56 PST
,
Michael Pruett
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Michael Pruett
Comment 1
2013-01-15 09:55:21 PST
Created
attachment 182795
[details]
Patch
Michael Pruett
Comment 2
2013-01-15 09:56:58 PST
Created
attachment 182796
[details]
Patch
Max Vujovic
Comment 3
2013-01-15 10:01:28 PST
Thanks for the fix! It looks good to me. Would you like to commit it? (As it's a build fix, I don't think you need a review from Dean.)
WebKit Review Bot
Comment 4
2013-01-15 10:35:32 PST
Comment on
attachment 182796
[details]
Patch Clearing flags on attachment: 182796 Committed
r139755
: <
http://trac.webkit.org/changeset/139755
>
WebKit Review Bot
Comment 5
2013-01-15 10:35:36 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug