Bug 106766 - [V8] Call Isolate::GetCurrent() in a callback from WebCore
Summary: [V8] Call Isolate::GetCurrent() in a callback from WebCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Reported: 2013-01-14 01:49 PST by Kentaro Hara
Modified: 2013-01-14 02:46 PST (History)
3 users (show)

See Also:

Patch (9.52 KB, patch)
2013-01-14 02:12 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-14 01:49:44 PST
The objective is to pass an Isolate everywhere. Given that a callback from WebCore is an entry point to V8, we can call Isolate::GetCurrent() at the head of the callback and pass it to other places. (In practice, handleEvent() is the only callback used in the current WebKit.)
Comment 1 Kentaro Hara 2013-01-14 02:12:26 PST
Created attachment 182531 [details]
Comment 2 WebKit Review Bot 2013-01-14 02:46:13 PST
Comment on attachment 182531 [details]

Clearing flags on attachment: 182531

Committed r139599: <http://trac.webkit.org/changeset/139599>
Comment 3 WebKit Review Bot 2013-01-14 02:46:16 PST
All reviewed patches have been landed.  Closing bug.