Bug 106498 - run-perf-tests --chromium-android --profile should show symbols for the kernel
Summary: run-perf-tests --chromium-android --profile should show symbols for the kernel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 15:18 PST by Eric Seidel (no email)
Modified: 2013-01-10 07:31 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.43 KB, patch)
2013-01-09 15:25 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-01-09 15:18:30 PST
run-perf-tests --chromium-android --profile should show symbols for the kernel
Comment 1 Eric Seidel (no email) 2013-01-09 15:25:50 PST
Created attachment 181998 [details]
Patch
Comment 2 Adam Barth 2013-01-09 17:47:39 PST
Comment on attachment 181998 [details]
Patch

ok.  We might want to have Peter take a look to make sure this is a sane thing to do.
Comment 3 WebKit Review Bot 2013-01-09 17:57:46 PST
Comment on attachment 181998 [details]
Patch

Clearing flags on attachment: 181998

Committed r139263: <http://trac.webkit.org/changeset/139263>
Comment 4 WebKit Review Bot 2013-01-09 17:57:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Peter Beverloo 2013-01-10 07:31:22 PST
This is pretty cool, thanks!

The approach looks fine to me, although I'm not familiar with kallsyms.