RESOLVED WONTFIX 106139
[chromium] Remove WebWidget::layerTreeView(), ownership is the other way around 
https://bugs.webkit.org/show_bug.cgi?id=106139
Summary [chromium] Remove WebWidget::layerTreeView(), ownership is the other way around
James Robinson
Reported 2013-01-04 15:13:28 PST
[chromium] Remove WebWidget::layerTreeView(), ownership is the other way around
Attachments
Patch (2.36 KB, patch)
2013-01-04 15:15 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
remove in header (3.02 KB, patch)
2013-01-04 15:17 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.02 KB, patch)
2013-01-04 15:22 PST, James Robinson 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-01-04 15:15:36 PST
Created attachment 181387 [details] Patch
James Robinson
Comment 2 2013-01-04 15:15:49 PST
Another easy one
Adrienne Walker
Comment 3 2013-01-04 15:17:20 PST
Comment on attachment 181387 [details] Patch R=me. Sure.
James Robinson
Comment 4 2013-01-04 15:17:59 PST
Created attachment 181388 [details] remove in header
James Robinson
Comment 5 2013-01-04 15:22:18 PST
Created attachment 181393 [details] Patch for landing
WebKit Review Bot
Comment 6 2013-01-05 12:24:21 PST
Comment on attachment 181393 [details] Patch for landing Rejecting attachment 181393 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: /WebWidget.h.rej patching file Source/WebKit/chromium/src/WebViewImpl.cpp Hunk #1 FAILED at 1733. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/WebViewImpl.cpp.rej patching file Source/WebKit/chromium/src/WebViewImpl.h Hunk #1 FAILED at 142. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/WebViewImpl.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15735220
Note You need to log in before you can comment on or make changes to this bug.