Bug 106029 - [GTK] TextTrack DOM Bindings won't build running autogen.sh manually
Summary: [GTK] TextTrack DOM Bindings won't build running autogen.sh manually
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xan Lopez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-03 12:29 PST by Xan Lopez
Modified: 2013-01-07 11:59 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.74 KB, patch)
2013-01-03 12:42 PST, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2013-01-03 12:29:43 PST
ENABLE_VIDEO_TRACK won't be defined, so the WebCore bits we need are missing. Patch coming.
Comment 1 Xan Lopez 2013-01-03 12:42:41 PST
Created attachment 181206 [details]
Patch
Comment 2 Zan Dobersek 2013-01-03 23:14:24 PST
Bug #105743 contains a patch that wraps the event target interface in build guards if a conditional is present on the IDL interface. This removes the compilation failures occurring when disabling video track.

The build targets behind the ENABLE_VIDEO automake variable should also be moved into the general list and the DOM bindings should still compile without failures, though I haven't looked into that yet and I won't guarantee it's at all possible.
Comment 3 Zan Dobersek 2013-01-07 11:59:02 PST
Fixed in bug #105743, landed as r138793.
http://trac.webkit.org/changeset/138793
Comment 4 Zan Dobersek 2013-01-07 11:59:43 PST
Comment on attachment 181206 [details]
Patch

Clearing review/cq flags.